# Review Comment

- **Author:** gemini-code-assist[bot]
- **File:** `packages/providers/fal/avatar-generation/fal_avatar/models/base.py`
- **Line:** 59
- **Date:** 2026-02-06
- **Comment ID:** 2772266411
- **URL:** https://github.com/donghaozhang/video-agent-skill/pull/19#discussion_r2772266411

---

![high](https://www.gstatic.com/codereviewagent/high-priority.svg)

The `try...except ValueError` block here hides a critical configuration error: when a model class is instantiated with a key that doesn't exist in the `ModelRegistry`. This leads to a silent failure where the model instance is not properly configured (e.g., `self.endpoint` is an empty string), causing non-obvious runtime errors downstream.

To ensure robustness and fail-fast behavior, this fallback logic should be removed. The `ModelRegistry.get()` call should be allowed to raise its `ValueError`, immediately signaling that a model is being used without being properly registered. The registry should be the absolute single source of truth.

```python
        self._definition = ModelRegistry.get(model_name)
        self.endpoint = self._definition.endpoint
        self.pricing = self._definition.pricing
        self.max_duration = self._definition.max_duration
        self.supported_resolutions = self._definition.resolutions
        self.supported_aspect_ratios = self._definition.aspect_ratios
```
