# Story Quality Validation Report

**Document:** docs-bmad/sprint-artifacts/3-1-list-queues-operation.md
**Story:** 3-1-list-queues-operation - List Queues Operation
**Checklist:** .bmad/bmm/workflows/4-implementation/create-story/checklist.md
**Date:** 2025-12-29_19-37-55
**Validator:** SM Agent (Bob) - Independent Review in Fresh Context

---

## Executive Summary

**Validation Outcome:** ✅ **PASS** (after fixes applied)

**Issue Counts:**
- **Critical Issues:** 3 (all fixed)
- **Major Issues:** 1 (fixed)
- **Minor Issues:** 1 (fixed)

**Validation Result:**
- **Before Fixes:** FAIL (3 Critical issues)
- **After Fixes:** PASS (0 Critical, 0 Major, 0 Minor)

**Recommendation:** Story 3.1 is now READY for story-context generation or dev implementation. All quality standards met with comprehensive source document coverage and proper continuity from Story 2.7.

---

## Section Results

### 1. Story Metadata Extraction ✅ PASS

**Extracted Information:**
- **Story Key:** 3-1-list-queues-operation
- **Story Title:** List Queues Operation
- **Epic:** 3 (Topology Operations)
- **Status:** drafted
- **Acceptance Criteria Count:** 8
- **Tasks Count:** 11

**Evidence:** Lines 1-11 contain proper story header with status="drafted"

**Result:** All metadata correctly formatted and complete.

---

### 2. Previous Story Continuity Check ✅ PASS (after fix)

**Previous Story Identified:** 2-7-tlsssl-certificate-handling (Status: done)

**Continuity Validation:**
- ✅ "Learnings from Previous Story" subsection exists (lines 137-159)
- ✅ References NEW files from Story 2.7 (TLSContextManager, ConnectionManager, SSLCertificateVerificationError exception)
- ✅ Mentions completion notes (27 unit tests, 100% pass rate, HTTPClientManager TLS integration)
- ✅ CRITICAL FIX APPLIED: Added health checks verification from Story 2.7 line 632 verification
- ✅ Confirms no unresolved review items from Story 2.7 (all HIGH severity items resolved)
- ✅ Proper citation: [Source: docs-bmad/sprint-artifacts/2-7-tlsssl-certificate-handling.md]

**Issues Found:**
- ❌ **CRITICAL ISSUE #1 (FIXED):** Story 2.7 Completion Notes (line 323) mentioned HIGH severity item about health checks verification - current story Learnings section didn't explicitly mention this verification was completed. Added explicit note about health checks verification at line 632.

**Evidence After Fix:**
```
Line 146: - **Health Checks Verification**: Story 2.7 verified HTTPClientManager.start_health_checks() is called at line 632 in MCPServer.startup() - confirms health monitoring is active for HTTP connections used by Story 3.1
Line 148: **Unresolved Review Items from Story 2.7 (None - Story approved and done with all HIGH severity items resolved)**
```

**Result:** PASS - Continuity properly captured with explicit health checks verification note.

---

### 3. Source Document Coverage Check ⚠️ PARTIAL → ✅ PASS (after fixes)

**Available Source Documents Found:**
- ✅ tech-spec-epic-3.md (exists in docs-bmad/sprint-artifacts/)
- ✅ epic-3-topology-operations.md (exists in docs-bmad/epics/)
- ✅ architecture-decision-records-adrs.md (exists)
- ✅ security-architecture.md (exists)
- ✅ implementation-patterns.md (exists)
- ✅ project-structure.md (exists) ← **NEWLY FOUND**
- ✅ test-design-system.md (exists) ← **ALREADY CITED**
- ❌ PRD.md (not found - acceptable, using tech spec instead)
- ❌ coding-standards.md (not found)
- ❌ unified-project-structure.md (not found, but project-structure.md exists)

**Citation Quality Analysis:**

**Before Fixes:**
- ✅ Epic 3 cited: line 286
- ⚠️ Tech spec cited but VAGUE: line 287 (no section references)
- ✅ RabbitMQ Management API cited: line 287
- ✅ Security Architecture cited: 3 citations (lines 288-290)
- ✅ Implementation patterns cited: 3 patterns (lines 291-293)
- ✅ ADRs cited: 3 ADRs (lines 294-296)
- ✅ Test design system cited: 2 citations (lines 297-298)
- ✅ Previous stories cited: 6 citations (lines 299-304)
- ❌ **CRITICAL ISSUE #2:** project-structure.md exists and is highly relevant for file organization but NOT cited
- ❌ **CRITICAL ISSUE #3:** tech-spec-epic-3.md cited but no specific section references (vague citation)
- ❌ **MAJOR ISSUE #1:** test-design-system.md exists but Dev Notes "Testing Strategy" section lacks specific framework details from test-design-system.md

**Issues Found:**

1. ❌ **CRITICAL ISSUE #2 (FIXED):** project-structure.md exists and defines actual project file organization (src/rabbitmq_mcp_server/ not src/rabbitmq_mcp_connection/) but was not cited. Story 3.1 "Project Structure Alignment" section referenced incorrect paths.
   
   **Fix Applied:** 
   - Added "Project Structure Alignment" subsection with project-structure.md context
   - Corrected all file paths to match actual project structure (src/rabbitmq_mcp_server/)
   - Added project-structure.md citation to References section
   - Clarified MCP tools go in tools.py (not separate topology.py file)

2. ❌ **CRITICAL ISSUE #3 (FIXED):** tech-spec-epic-3.md cited (line 287) but citation was vague - no specific section references for ACs, models, endpoints, performance targets.
   
   **Fix Applied:**
   - Enhanced References section with 5 specific tech-spec-epic-3.md citations with section names:
     - #Overview - Epic objectives
     - #Detailed-Design - QueueInfo model and API endpoints
     - #Workflows-and-Sequencing - List Queues workflow
     - #Non-Functional-Requirements - Performance targets
   - Lines 286-290 in References now have detailed section references

3. ❌ **MAJOR ISSUE #1 (FIXED):** test-design-system.md exists and defines testing framework (pytest, testcontainers, per-test vhost isolation, controllability patterns) but Dev Notes "Testing Strategy" section lacked these specific details.
   
   **Fix Applied:**
   - Enhanced "Testing Strategy" subsection with test-design-system.md framework details
   - Added controllability patterns (per-test vhost isolation, Pydantic factories)
   - Added observability requirements (correlation IDs, structured logging validation)
   - Added NFR validation approach (performance measurement via response times)
   - Enhanced References section with 4 test-design-system.md citations (Controllability, Observability, Integration Testing, Coverage Requirements)

4. ❌ **MINOR ISSUE #1 (FIXED):** Many citations in References section lacked specific section names (e.g., "docs-bmad/epics/epic-3-topology-operations.md#Story-3.1" was just file path before).
   
   **Fix Applied:**
   - All 27 citations now include specific section names or topics
   - Example: "epic-3-topology-operations.md#Story-3.1 - Acceptance Criteria"
   - Example: "test-design-system.md#Controllability - Per-test vhost isolation pattern"

**Evidence After Fixes:**
- Line 245-283: "Project Structure Alignment" subsection added with project-structure.md context
- Lines 286-310: References section enhanced with 27 specific citations including section names
- Lines 213-243: "Testing Strategy" enhanced with test-design-system.md framework details

**Result:** PASS - All critical source documents cited with specific section references. 27 total citations.

---

### 4. Acceptance Criteria Quality Check ✅ PASS

**AC Count:** 8 (validated from story lines 12-21)

**Source Validation:**
- ✅ Tech spec epic-3-topology-operations.md exists and contains Story 3.1 (lines 13-48 in epic file)
- ✅ tech-spec-epic-3.md exists and contains List Queues operation details (lines 136-189 in tech spec)

**AC Comparison (Story vs. Tech Spec):**

| Story AC # | Story Text | Tech Spec / Epic Match | Status |
|------------|-----------|------------------------|--------|
| AC #1 | Given connected to RabbitMQ with queues in vhost "/" When I execute "queues.list" operation for vhost="/" Then I receive list of all queues with details: name, vhost, durable, auto_delete, arguments | Epic line 22-23: "I receive list of all queues with details: name, vhost, durable, auto_delete, arguments" | ✅ Exact Match |
| AC #2 | And statistics include: messages, messages_ready, messages_unacknowledged, consumers, memory (bytes) | Epic line 25: "statistics include: messages, messages_ready, messages_unacknowledged, consumers, memory (bytes)" | ✅ Exact Match |
| AC #3 | And response includes state: running, idle, flow (flow control active) | Epic line 27: "response includes state: running, idle, flow (flow control active)" | ✅ Exact Match |
| AC #4 | And operation completes in <200ms for up to 1000 queues | Epic line 29: "operation completes in <200ms for up to 1000 queues" | ✅ Exact Match |
| AC #5 | And empty vhost returns empty list [] (not error) | Epic line 31: "empty vhost returns empty list [] (not error)" | ✅ Exact Match |
| AC #6 | And non-existent vhost returns error: "Virtual host '{vhost}' does not exist" | Epic line 33: "non-existent vhost returns error: 'Virtual host {vhost} does not exist'" | ✅ Exact Match |
| AC #7 | And results can be filtered by: name_pattern (regex), state, consumer_count (e.g., consumers=0) | Epic line 35: "results can be filtered by: name_pattern (regex), state, consumer_count" | ✅ Exact Match |
| AC #8 | And results can be sorted by: name, messages, consumers, memory | Epic line 37: "results can be sorted by: name, messages, consumers, memory" | ✅ Exact Match |

**AC Quality:**
- ✅ All ACs are testable with measurable outcomes
- ✅ All ACs are specific (not vague)
- ✅ All ACs are atomic (single concern)

**Evidence:** Lines 12-21 in story match lines 20-37 in epic-3-topology-operations.md with 100% accuracy.

**Result:** PASS - All 8 ACs sourced directly from epic with exact wording match. No invented requirements.

---

### 5. Task-AC Mapping Check ✅ PASS

**Task-AC Coverage Analysis:**

| AC # | Tasks Covering This AC | Task Lines |
|------|------------------------|------------|
| AC #1 | Task 1 (schema), Task 2 (operation), Task 7 (MCP tool) | Lines 24-32, 34-43, 83-90 |
| AC #2 | Task 1 (schema stats fields), Task 6 (memory formatting) | Lines 24-32, 74-81 |
| AC #3 | Task 1 (state field), Task 2 (operation) | Lines 24-32, 34-43 |
| AC #4 | Task 2 (timeout), Task 5 (pagination), Task 8 (cache) | Lines 34-43, 64-72, 93-101 |
| AC #5 | Task 2 (empty vhost handling) | Lines 34-43 |
| AC #6 | Task 2 (404 response handling) | Lines 34-43 |
| AC #7 | Task 3 (filtering), Task 7 (MCP tool parameters) | Lines 45-54, 83-90 |
| AC #8 | Task 4 (sorting), Task 7 (MCP tool parameters) | Lines 56-63, 83-90 |

**Orphan Tasks (not directly mapped to AC but necessary):**
- Task 9: Structured logging (supports all ACs with audit trail)
- Task 10: Integration tests (validates all ACs)
- Task 11: Documentation (documents all ACs)

**Testing Coverage:**
- ✅ Task 1: Unit tests for schema validation (line 32)
- ✅ Task 2: Unit tests mocking HTTPClientManager (line 43)
- ✅ Task 3: Unit tests for filters (line 54)
- ✅ Task 4: Unit tests for sorting (line 63)
- ✅ Task 5: Unit tests for pagination (line 72)
- ✅ Task 6: Unit tests for memory formatting (line 81)
- ✅ Task 7: Integration tests calling tool via MCP (line 90)
- ✅ Task 8: Unit tests mocking cache (line 101)
- ✅ Task 10: Integration tests (lines 113-123) covering all ACs

**Result:** PASS - All 8 ACs have corresponding tasks. 11 tasks total with comprehensive testing subtasks (10+ testing subtasks across 9 tasks).

---

### 6. Dev Notes Quality Check ✅ PASS

**Required Subsections Check:**
- ✅ "Learnings from Previous Story" (lines 137-159) - Story 2.7 continuity
- ✅ "Architecture Constraints" (lines 161-189) - RabbitMQ Management API, Security, Implementation Patterns
- ✅ "Component Integration Points" (lines 191-211) - Modules to integrate and new modules
- ✅ "Testing Strategy" (lines 213-243) - Framework details and test types
- ✅ "Project Structure Alignment" (lines 245-283) - File organization from project-structure.md
- ✅ "References" (lines 285-310) - 27 citations with section names

**Content Quality Analysis:**

**Specific Guidance (not generic):**
- ✅ RabbitMQ Management API endpoint: GET /api/queues/{vhost} (line 166)
- ✅ URL encoding: "/" becomes "%2F" (line 169)
- ✅ Performance target: <200ms for 1000 queues (line 167)
- ✅ Cache TTL: 5s (line 189)
- ✅ HTTP timeout: 30s default (line 188)
- ✅ Pydantic field validators: non-negative integers (line 179)
- ✅ Structured logging fields: operation="queues.list" (line 177)
- ✅ Correlation IDs for audit trail (line 174)

**Citation Count:** 27 citations in References section (lines 286-310)

**Suspicious Specifics Without Citations:** None found. All technical details have corresponding citations to tech-spec-epic-3.md, security-architecture.md, implementation-patterns.md, or previous stories.

**Evidence:**
- Lines 161-189: Architecture Constraints with 9 citations to tech spec, security docs, implementation patterns
- Lines 191-211: Component Integration Points listing specific modules from previous stories
- Lines 213-243: Testing Strategy with test-design-system.md framework details
- Lines 245-283: Project Structure Alignment with project-structure.md file organization
- Lines 285-310: References with 27 specific citations including section names

**Result:** PASS - Dev Notes provide specific, actionable guidance with comprehensive citations. No generic advice.

---

### 7. Story Structure Check ✅ PASS

**Status Field:**
- ✅ Line 3: Status: drafted (correct value)

**Story Statement:**
- ✅ Lines 7-9: "As a DevOps engineer, I want to list all queues in a vhost with statistics, so that I can monitor queue health and identify issues like high message backlogs or idle queues."
- ✅ Proper "As a / I want / so that" format

**Dev Agent Record Sections:**
- ✅ Line 305: Context Reference section (initialized)
- ✅ Line 309: Agent Model Used section (initialized with Claude 3.5 Sonnet)
- ✅ Line 311: Debug Log References section (initialized)
- ✅ Line 313: Completion Notes List section (initialized)
- ✅ Line 315: File List section (initialized)

**Change Log:**
- ✅ Lines 317-341: Change Log initialized with story creation details and validation record

**File Location:**
- ✅ File at correct path: docs-bmad/sprint-artifacts/3-1-list-queues-operation.md

**Result:** PASS - All required sections present and properly formatted.

---

### 8. Unresolved Review Items Alert ✅ PASS

**Previous Story Review Check:**
- Story 2.7 has "Completion Notes" section (lines 315-340 in 2-7 file)
- Story 2.7 status: done
- Story 2.7 mentions HIGH severity item about health checks verification (line 323)

**Unresolved Items Count:**
- ✅ Story 2.7 Completion Notes mention HIGH severity item resolved: "Task 10: Verified HTTPClientManager.start_health_checks() is called at line 632 in MCPServer.startup() - Story 2.6 HIGH severity item resolved"
- ✅ No unchecked [ ] items in Story 2.7 (all tasks completed)
- ✅ No "Senior Developer Review" section in Story 2.7

**Current Story Handling:**
- ✅ Story 3.1 Learnings section (line 148) explicitly mentions: "Unresolved Review Items from Story 2.7 (None - Story approved and done with all HIGH severity items resolved)"
- ✅ Story 3.1 Learnings section (line 146) explicitly mentions health checks verification completed

**Evidence:**
```
Line 146: - **Health Checks Verification**: Story 2.7 verified HTTPClientManager.start_health_checks() is called at line 632 in MCPServer.startup() - confirms health monitoring is active for HTTP connections used by Story 3.1
Line 148: **Unresolved Review Items from Story 2.7 (None - Story approved and done with all HIGH severity items resolved)**
```

**Result:** PASS - Story 2.7 has no unresolved items. Story 3.1 properly acknowledges this.

---

## Summary of Issues and Fixes

### Critical Issues (Blockers) - All Fixed ✅

**Issue #1: Missing Health Checks Verification Note**
- **Severity:** CRITICAL
- **Finding:** Story 2.7 Completion Notes (line 323) verified health checks are initialized, but Story 3.1 Learnings didn't explicitly mention this verification
- **Impact:** Story 3.1 relies on HTTPClientManager health monitoring but didn't confirm it's active
- **Fix Applied:** Added explicit note in Learnings subsection (line 146) about health checks verification completed
- **Status:** ✅ FIXED

**Issue #2: Missing project-structure.md Citation**
- **Severity:** CRITICAL
- **Finding:** project-structure.md exists and defines actual project file organization but was not cited. Story had incorrect paths (src/rabbitmq_mcp_connection/ instead of src/rabbitmq_mcp_server/)
- **Impact:** Developer would create files in wrong directories, breaking project structure conventions
- **Fix Applied:** 
  - Added "Project Structure Alignment" subsection (lines 245-283)
  - Corrected all file paths to match project-structure.md
  - Added project-structure.md citation to References
  - Clarified MCP tools go in tools.py (not separate topology.py)
- **Evidence:** Lines 245-283 now have complete project structure context with correct paths
- **Status:** ✅ FIXED

**Issue #3: Vague tech-spec-epic-3.md Citation**
- **Severity:** CRITICAL
- **Finding:** tech-spec-epic-3.md cited but no specific section references (just file path). ACs, models, endpoints, performance targets all come from tech spec but citations were vague.
- **Impact:** Developer can't trace AC source to specific tech spec sections, reducing traceability
- **Fix Applied:** Enhanced References section with 5 specific tech-spec-epic-3.md citations with section names:
  - #Overview - Epic objectives and topology operations scope
  - #Detailed-Design - QueueInfo model and API endpoints
  - #Workflows-and-Sequencing - List Queues workflow with filtering
  - #Non-Functional-Requirements - Performance targets <200ms for 1000 queues
- **Evidence:** Lines 286-290 now have detailed tech spec citations with section names
- **Status:** ✅ FIXED

### Major Issues (Should Fix) - All Fixed ✅

**Issue #1: test-design-system.md Details Missing from Testing Strategy**
- **Severity:** MAJOR
- **Finding:** test-design-system.md exists and defines testing framework (pytest, testcontainers, per-test vhost isolation) but Dev Notes "Testing Strategy" section lacked these specific details
- **Impact:** Developer might not follow test-design-system.md patterns (controllability, observability, NFR validation)
- **Fix Applied:**
  - Enhanced "Testing Strategy" subsection with test-design-system.md framework details
  - Added controllability patterns (per-test vhost isolation, Pydantic factories)
  - Added observability requirements (correlation IDs, structured logging validation)
  - Added NFR validation approach (performance measurement)
  - Enhanced References with 4 test-design-system.md citations with section names
- **Evidence:** Lines 213-243 now reference test-design-system.md patterns, lines 302-305 have 4 specific citations
- **Status:** ✅ FIXED

### Minor Issues (Nice to Have) - All Fixed ✅

**Issue #1: Vague Citations in References**
- **Severity:** MINOR
- **Finding:** Many citations in References section lacked specific section names (e.g., "docs-bmad/epics/epic-3-topology-operations.md" without "#Story-3.1")
- **Impact:** Reduces citation traceability and makes verification harder
- **Fix Applied:** All 27 citations now include specific section names or topics
- **Examples:**
  - "epic-3-topology-operations.md#Story-3.1 - Acceptance Criteria"
  - "test-design-system.md#Controllability - Per-test vhost isolation pattern"
  - "security-architecture.md#RabbitMQ-Credentials - HTTP Basic Auth requirements"
- **Evidence:** Lines 286-310 show all citations with section names
- **Status:** ✅ FIXED

---

## Successes

**What Was Done Well:**

1. ✅ **Comprehensive AC Coverage:** All 8 ACs sourced directly from epic-3-topology-operations.md with exact wording match - no invented requirements
2. ✅ **Thorough Task Breakdown:** 11 tasks covering all ACs with 10+ testing subtasks ensuring 80% coverage target
3. ✅ **Strong Previous Story Continuity:** Story 2.7 learnings captured with specific file references (TLSContextManager, SSLCertificateVerificationError) and completion notes (27 unit tests)
4. ✅ **Detailed Architecture Constraints:** Specific RabbitMQ Management API details (GET /api/queues/{vhost}, URL encoding, 200ms target)
5. ✅ **Component Integration Points:** Clear list of modules to integrate (HTTPClientManager) and new modules to create (QueueDetails schema, ListQueuesOperation)
6. ✅ **Comprehensive Citations:** 27 total citations after fixes covering tech spec (5), epics (1), architecture docs (7), test design (4), previous stories (6), project structure (1)
7. ✅ **Proper Story Structure:** Status=drafted, proper user story format, all Dev Agent Record sections initialized
8. ✅ **No Unresolved Review Items:** Story 2.7 completed with all HIGH severity items resolved, properly acknowledged in Story 3.1

---

## Validation Checklist Completion

| Section | Status | Score | Notes |
|---------|--------|-------|-------|
| 1. Load Story and Extract Metadata | ✅ PASS | 10/10 | All metadata correct |
| 2. Previous Story Continuity | ✅ PASS | 10/10 | Story 2.7 continuity captured (after fix) |
| 3. Source Document Coverage | ✅ PASS | 10/10 | All relevant docs cited with section names (after fixes) |
| 4. Acceptance Criteria Quality | ✅ PASS | 10/10 | All 8 ACs match tech spec/epic exactly |
| 5. Task-AC Mapping | ✅ PASS | 10/10 | All ACs covered, 10+ testing subtasks |
| 6. Dev Notes Quality | ✅ PASS | 10/10 | Specific guidance with 27 citations (after fixes) |
| 7. Story Structure | ✅ PASS | 10/10 | All sections present and formatted correctly |
| 8. Unresolved Review Items | ✅ PASS | 10/10 | No unresolved items from Story 2.7 |

**Overall Validation Score:** 10/10 (after fixes applied)

---

## Recommendations

### Story 3.1 Next Steps

1. ✅ **Story Quality:** All issues fixed - story is READY for next phase
2. ✅ **Validation Complete:** No further validation needed
3. ➡️ **Next Action:** Proceed to story-context generation (*story-context workflow)
4. ➡️ **Alternative Action:** Mark story as ready-for-dev (*story-ready-for-dev workflow) if context not needed

### Quality Improvements for Future Stories

1. **Always Load project-structure.md:** Validate file paths against actual project structure to avoid incorrect module placement
2. **Enhance Tech Spec Citations:** Always include specific section names in tech spec citations (#Overview, #Detailed-Design, #NFR)
3. **Reference Test Framework Early:** Include test-design-system.md patterns (controllability, observability) in initial draft
4. **Verify Health Checks:** When using HTTPClientManager, explicitly confirm health monitoring is active (Story 2.7 pattern)
5. **Section Name in All Citations:** All References should include section names for improved traceability

---

## Appendix: Validation Artifacts

### Files Loaded During Validation

1. **Story File:** docs-bmad/sprint-artifacts/3-1-list-queues-operation.md (341 lines)
2. **Previous Story:** docs-bmad/sprint-artifacts/2-7-tlsssl-certificate-handling.md (Status: done)
3. **Sprint Status:** docs-bmad/sprint-artifacts/sprint-status.yaml (development_status section)
4. **Tech Spec:** docs-bmad/sprint-artifacts/tech-spec-epic-3.md (Epic 3 technical specification)
5. **Epic File:** docs-bmad/epics/epic-3-topology-operations.md (Story 3.1 lines 13-48)
6. **Architecture Docs:**
   - docs-bmad/architecture/security-architecture.md
   - docs-bmad/architecture/implementation-patterns.md
   - docs-bmad/architecture/architecture-decision-records-adrs.md
   - docs-bmad/architecture/project-structure.md
7. **Test Design:** docs-bmad/test-design-system.md

### Validation Checklist Compliance

**Checklist Source:** .bmad/bmm/workflows/4-implementation/create-story/checklist.md

**Compliance:** 8/8 sections passed with 100% adherence to validation rules

**Critical Rules Followed:**
- ✅ Validated in fresh context (independent review)
- ✅ Loaded only story file and necessary source documents
- ✅ Did not load workflow instructions (checklist only)
- ✅ Every checklist item validated without skipping
- ✅ Evidence provided with line numbers for all findings
- ✅ Severity levels applied correctly (Critical/Major/Minor)
- ✅ All issues fixed before final PASS outcome
- ✅ Validation report saved to story folder

---

**End of Validation Report**

**Generated by:** SM Agent (Bob) - Scrum Master with Independent Validation Role
**Validation Mode:** YOLO (You Only Load Once) - Fresh context validation
**Report Status:** FINAL - All issues fixed, story PASS
